You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds SetScreenSettingsOverrideAsync method in Emulation module.
🔄 Types of changes
New feature (non-breaking change which adds functionality and tests!)
PR Type
Enhancement
Description
Adds SetScreenSettingsOverrideAsync method to Emulation module
Implements command, parameters, options, and result types
Includes comprehensive test coverage with browser compatibility checks
Diagram Walkthrough
flowchart LR
A["EmulationModule"] -->|"adds method"| B["SetScreenSettingsOverrideAsync"]
B -->|"uses"| C["SetScreenSettingsOverrideCommand"]
C -->|"with parameters"| D["SetScreenSettingsOverrideParameters"]
D -->|"contains"| E["ScreenArea"]
C -->|"returns"| F["SetScreenSettingsOverrideResult"]
G["EmulationTest"] -->|"tests"| B
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: No audit logs: The new SetScreenSettingsOverrideAsync action appears to change emulation state without any added audit logging or metadata capturing who/what initiated it.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: Input validation: The new ScreenArea lacks validation for non-positive width/height and the API path does not handle null/invalid parameters beyond passing them to the broker.
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities
Status: Missing validation: External inputs like ScreenArea and context lists are forwarded without validation or range checks which could allow invalid values to reach lower layers.
Honestly I don't know what is the best approach to ship binding without internal testing: remote end doesn't support it (yet?). Merging it with assumption we will return to it and unignore tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
https://w3c.github.io/webdriver-bidi/#command-emulation-setScreenSettingsOverride
💥 What does this PR do?
Adds
SetScreenSettingsOverrideAsyncmethod in Emulation module.🔄 Types of changes
PR Type
Enhancement
Description
Adds
SetScreenSettingsOverrideAsyncmethod to Emulation moduleImplements command, parameters, options, and result types
Includes comprehensive test coverage with browser compatibility checks
Diagram Walkthrough
File Walkthrough
EmulationModule.cs
Add SetScreenSettingsOverrideAsync method implementationdotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs
SetScreenSettingsOverrideAsyncmethod following existing patternSetScreenSettingsOverrideCommandandSetScreenSettingsOverrideResultfor JSON serializationSetScreenSettingsOverrideCommand.cs
Implement SetScreenSettingsOverride command and related typesdotnet/src/webdriver/BiDi/Emulation/SetScreenSettingsOverrideCommand.cs
SetScreenSettingsOverrideCommandfor BiDicommunication
SetScreenSettingsOverrideParametersrecord withScreenAreaproperty
SetScreenSettingsOverrideOptionswith context and usercontext support
ScreenArearecord with width and height propertiesSetScreenSettingsOverrideResultas empty result typeEmulationTest.cs
Add test for SetScreenSettingsOverride functionalitydotnet/test/common/BiDi/Emulation/EmulationTest.cs
CanSetScreenSettingsOverrideto verify functionalityFirefox
ScreenAreaparameter and context options